CBlog

Happy Towel Day!

I know I'm a bit late for the people living in germany, but it's still early enough for those living on the other side of the planet ;-) - especially for the other AppArmor developers!

Yesterday and today, I sent a flood of patches to the AppArmor mailinglist. You can easily see this as a (productive) DoS attack because AppArmor has a policy that every patch must be reviewed within a week...

Including some patches from the last days that didn't get a review yet, I have the answer - 42 patches pending for the AppArmor utils :-)

The biggest patches move the handling of change_profile and rlimit rules into classes and add tests for them. Another set of patches starts to unify the code of aa-logprof and aa-mergeprof (and fixes some bugs while doing that). The patch flood also contains some small bugfix and cleanup patches.

I'm quite sure the other developers will need some time to review all those patches *g*

If you are interested what exactly I changed, have a look at the AppArmor mailinglist archive and check my mails with the [patch] prefix.

For those who are more interested in statistics, here's the diffstat of my patch flood:

 /aa-mergeprof                         |  517 +++++++++++++---------------------
 /apparmor/aa.py                       |  363 +++++++++--------------
 /apparmor/regex.py                    |    7
 /apparmor/rule/__init__.py            |   41 ++
 /apparmor/rule/capability.py          |   11
 /apparmor/rule/change_profile.py      |   19 +
 /apparmor/severity.py                 |   13
 /apparmor/tools.py                    |   11
 /test/minitools_test.py               |   11
 /test/test-aa.py                      |   29 +
 /test/test-baserule.py                |    5
 /test/test-capability.py              |   32 ++
 /test/test-change_profile.py          |   18 +
 /test/test-severity.py                |   25 -
 utils/aa-audit                        |    1
 utils/aa-cleanprof                    |    1
 utils/aa-complain                     |    1
 utils/aa-disable                      |    1
 utils/aa-enforce                      |    1
 utils/aa-mergeprof                    |   50 ++-
 utils/apparmor/aa.py                  |   34 --
 utils/apparmor/regex.py               |   10
 utils/apparmor/rule/__init__.py       |    6
 utils/apparmor/rule/capability.py     |   14
 utils/apparmor/rule/change_profile.py |  173 +++++++++++
 utils/apparmor/rule/network.py        |   16 +
 utils/apparmor/rule/rlimit.py         |  265 +++++++++++++++++
 utils/apparmor/severity.py            |    4
 utils/apparmor/tools.py               |    7
 utils/test/common_test.py             |   22 +
 utils/test/minitools_test.py          |   25 -
 utils/test/test-aa.py                 |   55 +++
 utils/test/test-baserule.py           |    4
 utils/test/test-capability.py         |   46 ---
 utils/test/test-change_profile.py     |  443 +++++++++++++++++++++++++++++
 utils/test/test-example.py            |    4
 utils/test/test-network.py            |   17 +
 utils/test/test-rlimit.py             |  468 ++++++++++++++++++++++++++++++
 utils/test/test-severity.py           |  201 ++++---------
 39 files changed, 2183 insertions(+), 788 deletions(-)